Repository navigation
fix: skip coverage grade comment on fork PRs - #14299
Merged
DaanHoogland merged 2 commits intoOct 21, 2026
Merged
Conversation
2 tasks done
Damans227
reviewed
Oct 14, 2026
Damans227
reviewed
Oct 14, 2026
PrashantBhanage
changed the title
Contributor
|
ci only, might just merge (despite what @andrijapanicsb or anybody says) if GHA pass. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14299 +/- ##
============================================
+ Coverage 19.91% 20.40% +0.48%
- Complexity 20199 21285 +1086
============================================
Files 6373 6481 +108
Lines 577230 588040 +10810
Branches 70696 72021 +1325
============================================
+ Hits 114950 119962 +5012
- Misses 449713 455057 +5344
- Partials 12567 13021 +454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Awesome work, congrats on your first merged pull request! |
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR skips the "Post Coverage Grade Comment on PR" step on fork PRs. On forks the token is read-only, so posting the comment fails with a 403. The step now uses the same condition as the "Upload to SonarQube" step.
It also falls back to
N/Awhen branch coverage is not available.This change was separated from #13490 as requested by @DaanHoogland.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
N/A
How Has This Been Tested?
Checked the diff against
apache:main. Only.github/workflows/sonar-check.ymlchanges. No application code or unit tests were changed.How did you try to break this feature and the system with this change?
On fork PRs the comment step is now skipped, so it no longer tries to post with the read-only token. Fork PRs will not get a coverage comment. On PRs from the main repo the step runs as before.